Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New opendap dataformat #570

Merged
merged 5 commits into from
Feb 22, 2023
Merged

New opendap dataformat #570

merged 5 commits into from
Feb 22, 2023

Conversation

aulemahal
Copy link
Contributor

@aulemahal aulemahal commented Feb 3, 2023

Change Summary

Adds a new data format : "opendap".

Related issue number

Fixes #520.

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

Before going further in adding tests and documentation, I wanted to get some feedback on this, because I'm not sure I fully understand what fsspec does here.

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - can you add a test here?

@mgrover1
Copy link
Collaborator

@aulemahal - can you merge the latest changes from main here? This should fix the failing docs.

@aulemahal
Copy link
Contributor Author

Here we are!

The new test simply checks that the dataset opens with to_dask. The new test catalog lists datasets from Nasa's Hyrax Test Opendap website, specifically a list of Pathfinder's SST maps. I am not familiar with this data, I simply wanted a list of easy access opendap streams that we can play with. Thus, the catalog columns "first_swap", "last_swap" and "scode" are pure guesses as to what those mean in the file path.

Also, I added pydap to the testing environment. I am not aware of a method to see if a dataset open with netCDF4 uses OpenDap or if it was downloade on-the-fly. Whereas, pydap will just fail if the source is not an opendap stream. Also, pydap better supports opendap authentification, if we ever want to test that?

I plan on using this new catalog in #569 too, by removing the aggregation_control entry completely.

@aulemahal aulemahal marked this pull request as ready for review February 20, 2023 23:02
@mgrover1 mgrover1 merged commit 1086177 into intake:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error using to_dataset_dict() with opendap url as path
2 participants