Add support for auto_delete_head_branch #265
Conversation
ghost
added
the
github/resource_github_repository.go
Outdated
| @@ -137,6 +136,10 @@ func resourceGithubRepository() *schema.Resource { | |||
| Type: schema.TypeString, | |||
| Computed: true, | |||
| }, | |||
| "auto_delete_head_branch": { | |||
| Type: schema.TypeBool, | |||
| Computed: true, | |||
There was a problem hiding this comment.
Why is this marked as 'Computed'? When the API allows it, I'm going to want to be able to adjust this setting on my repositories from within Terraform, so this will have to be a normal setting, not a computed setting.
There was a problem hiding this comment.
Thanks @kpfleming I've addressed this now, I can't do much more until #342 is merged.
|
currently blocked by #342 |
Update mastter
|
Hey folks, any updates on this? |
|
Sorry, I've had a hectic few weeks at work, I'll try get this done before the end of next week |
Anything I can do to help get this one in @TomTucka ? |
|
@TomTucka any movement here? If I can help in any way to wrap it up let me know would love to close this one off on our end. |
|
How about we give @TomTucka another week to respond? If there are no objections in a week, @stefansedich please pick up the work needed to close this out. From what I can tell, this just needs to be rebased and perhaps have acceptance tests updated to include this code path. I have a few things I'd like to get released ahead of this so deferring to the next minor release works best on my end. Thanks for the additional patience on this one 😅 |
|
I believe https://github.com/terraform-providers/terraform-provider-github/pull/399 resolves the issue as well. I plan to proceed with that PR instead and will circle back to this one if things do not work out. |
Relates to #264
Waiting on
go-githubto support this.