Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for auto_delete_head_branch #265

Closed
wants to merge 5 commits into from
Closed

Add support for auto_delete_head_branch #265

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4b2f5b
Add support for auto_delete_head_branch
Aug 6, 2019
7887dca
Make auto_delete_head_branch an optional
Feb 17, 2020
b59bfd7
Add auto_delete_head_branch to docs
Feb 18, 2020
ba152a8
Merge branch 'master' into master
TomTucka Feb 18, 2020
9e07c1a
Merge pull request #1 from terraform-providers/master
Feb 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion github/resource_github_repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ func resourceGithubRepository() *schema.Resource {
ValidateFunc: validation.StringMatch(regexp.MustCompile(`^[a-z0-9][a-z0-9-]*$`), "must include only lowercase alphanumeric characters or hyphens and cannot start with a hyphen"),
},
},

"full_name": {
Type: schema.TypeString,
Computed: true,
Expand Down Expand Up @@ -137,6 +136,10 @@ func resourceGithubRepository() *schema.Resource {
Type: schema.TypeString,
Computed: true,
},
"auto_delete_head_branch": {
Type: schema.TypeBool,
Computed: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this marked as 'Computed'? When the API allows it, I'm going to want to be able to adjust this setting on my repositories from within Terraform, so this will have to be a normal setting, not a computed setting.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kpfleming I've addressed this now, I can't do much more until #342 is merged.

},
},
}
}
Expand All @@ -159,6 +162,7 @@ func resourceGithubRepositoryObject(d *schema.ResourceData) *github.Repository {
GitignoreTemplate: github.String(d.Get("gitignore_template").(string)),
Archived: github.Bool(d.Get("archived").(bool)),
Topics: expandStringList(d.Get("topics").(*schema.Set).List()),

}
}

Expand Down