Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Tests for missing accessor functions #1265

Merged
merged 11 commits into from
Nov 8, 2022
Merged

[SYCL] Tests for missing accessor functions #1265

merged 11 commits into from
Nov 8, 2022

Conversation

KornevNikita
Copy link

sycl patch: intel/llvm#6781

@KornevNikita KornevNikita requested a review from a team as a code owner September 14, 2022 14:29
@KornevNikita KornevNikita mentioned this pull request Sep 14, 2022
Merged
AlexeySachkov pushed a commit to intel/llvm that referenced this pull request Sep 22, 2022
@KornevNikita
[SYCL] Implement missing accessor functions (#6781)
f1f907a 
E2E tests: intel/llvm-test-suite#1265
@KornevNikita
Copy link
Author

Re-run tests

@KornevNikita KornevNikita reopened this Oct 11, 2022
@KornevNikita KornevNikita reopened this Oct 20, 2022
@KornevNikita KornevNikita mentioned this pull request Oct 27, 2022
Merged
@pvchupin
Copy link

@cperkinsintel, please review

@KornevNikita
Copy link
Author

@pvchupin @cperkinsintel just to note - intel/llvm#7201 should fix CI

@pvchupin
Copy link

@pvchupin @cperkinsintel just to note - intel/llvm#7201 should fix CI

I'm confused. intel/llvm#6781 is merged. The other two are not.
What should be merge sequence for the remaining ones?

@KornevNikita
Copy link
Author

@pvchupin now I'm confused:) which two are you talking about?
Originally, this test-suite patch was for intel/llvm#6781 and it was passing previously.
But, after intel/llvm#6853 this test-suite patch is out of date and getting failed.
So, to address this failure I've made intel/llvm#7201. After #7201 is merged, this patch's testing should pass.
Now it is clear for you?

@pvchupin
Copy link

@KornevNikita I was talking about #1265 and intel/llvm#7201

aelovikov-intel
aelovikov-intel reviewed Oct 28, 2022
View reviewed changes
SYCL/Basic/accessor/accessor.cpp Outdated Show resolved Hide resolved
SYCL/Basic/accessor/accessor.cpp Outdated Show resolved Hide resolved
SYCL/Basic/accessor/accessor.cpp Outdated Show resolved Hide resolved
SYCL/Basic/accessor/accessor.cpp Outdated Show resolved Hide resolved
SYCL/Basic/accessor/accessor.cpp Outdated Show resolved Hide resolved
SYCL/Basic/accessor/accessor.cpp Outdated Show resolved Hide resolved
SYCL/Basic/accessor/accessor.cpp Outdated Show resolved Hide resolved
@KornevNikita
Copy link
Author

@cperkinsintel could you take a look please? @pvchupin or Andrey's approve is enough?

@aelovikov-intel
Copy link

@cperkinsintel could you take a look please? @pvchupin or Andrey's approve is enough?

Technically it's enough and you can summon @intel/llvm-gatekeepers .

@pvchupin pvchupin merged commit 0bcef07 into intel:intel Nov 8, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
@KornevNikita @bb-sycl
[SYCL] Tests for missing accessor functions (intel#1265)
1feccc2 
sycl patch: intel/llvm#6781
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@KornevNikita
[SYCL] Tests for missing accessor functions (intel/llvm-test-suite#1265)
8a5ef86 
sycl patch: intel#6781
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel cperkinsintel is a code owner automatically assigned from intel/llvm-reviewers-runtime

@AlexeySachkov AlexeySachkov Awaiting requested review from AlexeySachkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KornevNikita @pvchupin @aelovikov-intel