Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Implement missing accessor functions #6781

Merged
merged 8 commits into from
Sep 22, 2022

Conversation

KornevNikita
Copy link
Contributor

@KornevNikita KornevNikita commented Sep 14, 2022

llvm-test-suite patch: intel/llvm-test-suite#1265

@KornevNikita KornevNikita requested a review from a team as a code owner September 14, 2022 14:28
@KornevNikita KornevNikita changed the title Missing acc funcs [SYCL] Implement missing accessor functions Sep 14, 2022
@KornevNikita
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1265

@KornevNikita
Copy link
Contributor Author

@AlexeySachkov @steffenlarsen @dm-vodopyanov could you take a look please

dm-vodopyanov
dm-vodopyanov previously approved these changes Sep 14, 2022
Copy link
Contributor

@dm-vodopyanov dm-vodopyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KornevNikita
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1265

@KornevNikita
Copy link
Contributor Author

@AlexeySachkov take a look please. Failures unrelated

@AlexeySachkov
Copy link
Contributor

@AlexeySachkov take a look please. Failures unrelated

@KornevNikita, could you please resolve conflicts?

@KornevNikita
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1265

@AlexeySachkov AlexeySachkov merged commit f1f907a into intel:sycl Sep 22, 2022
@pvchupin
Copy link
Contributor

@KornevNikita please check Windows post-commit fail: https://github.com/intel/llvm/actions/runs/3107743966/jobs/5036187282

@KornevNikita KornevNikita deleted the missing-acc-funcs branch September 23, 2022 10:07
pvchupin pushed a commit to intel/llvm-test-suite that referenced this pull request Nov 8, 2022
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants