Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX-issue#99] Allowing negative logic index values #155

Merged
merged 13 commits into from
Oct 12, 2022
Merged

[FIX-issue#99] Allowing negative logic index values #155

merged 13 commits into from
Oct 12, 2022

Conversation

RPG-coder-intc
Copy link
Contributor

@RPG-coder-intc RPG-coder-intc commented Aug 26, 2022 •
edited
Loading

Issue #99

  • Now one can use negative values in indices for indexing or subset slicing.
  • This effect is applied on BusSubset that is used by Logic slice()
  • Indirectly this effect is also passed to function that uses slice() like operator[] (indexing operator) and getRange()

@RPG-coder-intc
Copy link
Contributor Author

  • getRange() Exception handling are redundant as it is handled by BusSubset() contructor within slice()

mkorbel1
mkorbel1 requested changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs unit testing and documentation! Great start!

@RPG-coder-intc
Copy link
Contributor Author

Just needs unit testing and documentation! Great start!

Thanks Max!! Will do it asap.

@RPG-coder-intc RPG-coder-intc marked this pull request as ready for review September 2, 2022 14:08
@RPG-coder-intc
Copy link
Contributor Author

Just needs unit testing and documentation! Great start!

Made Changes as requested!

@RPG-coder-intc RPG-coder-intc requested review from mkorbel1 and chaparalas and removed request for mkorbel1 and chaparalas September 2, 2022 14:09
mkorbel1
mkorbel1 requested changes Sep 2, 2022
View reviewed changes
lib/src/values/logic_value.dart Show resolved Hide resolved
test/bus_test.dart Outdated Show resolved Hide resolved
lib/src/values/logic_value.dart Show resolved Hide resolved
mkorbel1
mkorbel1 reviewed Sep 2, 2022
View reviewed changes
lib/src/logic.dart Outdated Show resolved Hide resolved
@RPG-coder-intc RPG-coder-intc marked this pull request as draft September 2, 2022 17:00
@mkorbel1
Copy link
Contributor

mkorbel1 commented Oct 6, 2022

PR #174 is adding a bunch more lint checks, which will probably flag some new issues for you if you get in after that (when you pull the changes in). I'll wait a little bit to give you an opportunity to beat the PR in, but in the next day or two it will go in and then you'll have a little clean-up to do.

mkorbel1
mkorbel1 requested changes Oct 11, 2022
View reviewed changes
lib/src/utilities/traverseable_collection.dart Outdated Show resolved Hide resolved
lib/src/values/logic_value.dart Outdated Show resolved Hide resolved
test/bus_test.dart Show resolved Hide resolved
@RPG-coder-intc RPG-coder-intc marked this pull request as ready for review October 11, 2022 19:12
mkorbel1
mkorbel1 requested changes Oct 11, 2022
View reviewed changes
lib/src/logic.dart Outdated Show resolved Hide resolved
lib/src/logic.dart Outdated Show resolved Hide resolved
lib/src/logic.dart Outdated Show resolved Hide resolved
lib/src/utilities/simcompare.dart Outdated Show resolved Hide resolved
lib/src/values/logic_value.dart Outdated Show resolved Hide resolved
mkorbel1
mkorbel1 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@mkorbel1 mkorbel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mkorbel1 mkorbel1 merged commit a5ac328 into intel:main Oct 12, 2022
@RPG-coder-intc
Copy link
Contributor Author

Thanks!

@RPG-coder-intc RPG-coder-intc deleted the fix-issue-99 branch October 24, 2022 19:46
@mkorbel1 mkorbel1 linked an issue Dec 16, 2022 that may be closed by this pull request
Allow negative indices on Logic and LogicValue to relative to the end #99
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkorbel1 mkorbel1 mkorbel1 approved these changes

@chaparalas chaparalas chaparalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow negative indices on Logic and LogicValue to relative to the end
3 participants
@RPG-coder-intc @mkorbel1 @chaparalas