Upgrade lints package, make lints more strict, and fix new lint errors #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chykon
reviewed
Oct 6, 2022
chykon
reviewed
Oct 6, 2022
|
Thank you @chykon for the suggestions and feedback here! |
This was referenced Oct 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
The "lints" package was on an old version, so this PR upgrades it.
The lints were too lenient (many rules disabled), so this PR enables many more.
The new lint checks flagged many issues
Related Issue(s)
Fix #165
A lint check caught #170, so to fix the lint issue the issue was fixed, but no new tests are opened so the issue is left open until it is properly tested.
Testing
Existing tests cover functionality.
Reran
dart doc .to ensure that documentation fixes are clean.Backwards-compatibility
No, though some new warnings may appear.
Documentation
Yes, lint issues related to documentation were fixed.