-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup unused and deprecated code #1152
Conversation
extra_pages: h as _, | ||
}); | ||
|
||
let executor = NativeElseWasmExecutor::<Executor>::new_with_wasm_executor( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the native executor is soon going to be deprecated, I saw some other projects such as Acala and Bifrost only use the WASM executor now so we may also consider following suit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a source on this? The native executor is a lot more efficient so isn't it preferable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/run_benchmarks |
Request: Running... |
/run_benchmarks interlay |
Request: Running... |
/run_benchmarks interlay-dev |
Request: Running... |
/run_benchmarks interlay-dev |
1 similar comment
/run_benchmarks interlay-dev |
Request: Running... |
/run_benchmarks interlay-dev |
1 similar comment
/run_benchmarks interlay-dev |
Request: Running... |
/run_benchmarks interlay-dev |
Request: Running... |
/run_benchmarks interlay-dev |
Request: Running... |
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
6e956d2
to
7403064
Compare
/run_benchmarks interlay-dev |
Request: Running... |
Making this PR to run the benchmarks for the release, no functional changes are included.