Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

polkadot-collator: Switch to wasm only #1054

Merged
merged 4 commits into from
Mar 2, 2022
Merged

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Feb 28, 2022

This switches the polkadot-collator to run everything in wasm only mode. While we should not that
yet with the relay chain, because it can happen that we run out of memory (very unlikely). On the
relay chain that would be bad, because we only have at max 2 sessions to bring everything back, for
Parachains that isn't such a problem as they would only stall and we could roll out a release that
fixes it. Besides that, Parachain validation on the relay chain happens in Wasm already all the time
and there is the memory usage even higher then on block import.

Progress on: #984

This switches the polkadot-collator to run everything in wasm only mode. While we should not that
yet with the relay chain, because it can happen that we run out of memory (very unlikely). On the
relay chain that would be bad, because we only have at max 2 sessions to bring everything back, for
Parachains that isn't such a problem as they would only stall and we could roll out a release that
fixes it. Besides that, Parachain validation on the relay chain happens in Wasm already all the time
and there is the memory usage even higher then on block import.
@bkchr bkchr added A0-pleasereview B0-silent Changes should not be mentioned in any release notes labels Feb 28, 2022
Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skunert
Copy link
Contributor

skunert commented Mar 2, 2022

After this change, will the --execution flag not be useless? Can we remove it?

@bkchr
Copy link
Member Author

bkchr commented Mar 2, 2022

After this change, will the --execution flag not be useless? Can we remove it?

Not that easy at the moment.

@gilescope
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 92313f6 into master Mar 2, 2022
@paritytech-processbot paritytech-processbot bot deleted the bkchr-only-wasm branch March 2, 2022 11:44
jasl added a commit to Phala-Network/khala-parachain that referenced this pull request Mar 26, 2022
jasl added a commit to Phala-Network/khala-parachain that referenced this pull request Mar 28, 2022
AurevoirXavier added a commit to darwinia-network/darwinia-parachain that referenced this pull request May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants