This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 379
polkadot-collator: Switch to wasm only #1054
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches the polkadot-collator to run everything in wasm only mode. While we should not that yet with the relay chain, because it can happen that we run out of memory (very unlikely). On the relay chain that would be bad, because we only have at max 2 sessions to bring everything back, for Parachains that isn't such a problem as they would only stall and we could roll out a release that fixes it. Besides that, Parachain validation on the relay chain happens in Wasm already all the time and there is the memory usage even higher then on block import.
bkchr
added
A0-pleasereview
B0-silent
Changes should not be mentioned in any release notes
labels
Feb 28, 2022
gilescope
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After this change, will the |
wigy-opensource-developer
approved these changes
Mar 2, 2022
Not that easy at the moment. |
skunert
approved these changes
Mar 2, 2022
bot merge |
jasl
added a commit
to Phala-Network/khala-parachain
that referenced
this pull request
Mar 26, 2022
jasl
added a commit
to Phala-Network/khala-parachain
that referenced
this pull request
Mar 28, 2022
AurevoirXavier
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
May 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the polkadot-collator to run everything in wasm only mode. While we should not that
yet with the relay chain, because it can happen that we run out of memory (very unlikely). On the
relay chain that would be bad, because we only have at max 2 sessions to bring everything back, for
Parachains that isn't such a problem as they would only stall and we could roll out a release that
fixes it. Besides that, Parachain validation on the relay chain happens in Wasm already all the time
and there is the memory usage even higher then on block import.
Progress on: #984