Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(backend): add polymorphic ConnectorAccount interface #227

Merged
merged 2 commits into from
Feb 2, 2022
Merged

chore(backend): add polymorphic ConnectorAccount interface #227

merged 2 commits into from
Feb 2, 2022

Conversation

wilsonianb
Copy link
Contributor

@wilsonianb wilsonianb commented Feb 2, 2022 •
edited
Loading

Changes proposed in this pull request

  • Use model instances directly as connector accounts
  • Make model class definitions explicit about implementing ConnectorAccount and/or LiquidityAccount

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass

@github-actions github-actions bot added pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related labels Feb 2, 2022
@wilsonianb wilsonianb marked this pull request as ready for review February 2, 2022 18:14
@wilsonianb wilsonianb merged commit 578927b into main Feb 2, 2022
@wilsonianb wilsonianb deleted the bw-connector-account branch February 2, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentientwaffle sentientwaffle sentientwaffle approved these changes

@matdehaast matdehaast Awaiting requested review from matdehaast

@sabineschaller sabineschaller Awaiting requested review from sabineschaller

Assignees
No one assigned
Labels
pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wilsonianb @sentientwaffle