Skip to content

Commit

Permalink
fix: windows compat issues with pnpm dev cmd & env var syntax (#1743)
Browse files Browse the repository at this point in the history
* fix win compat issues with pnpm dev cmd and env var syntax

* readme

* add cross-env

---------

Co-authored-by: darian <darian@interledger.org>
  • Loading branch information
DarianM and darian authored Nov 5, 2024
1 parent 24859d9 commit d50071c
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 8 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ pnpm dev #this will start the project in hot reload mode for backend containers.
other options to start the local env are:

```sh
pnpm dev:debug #backend containers will not have hot reload feture enabled but will expose and have node `--inspect` option set with wallet container debug port set to 9229 and boutique port set to 9230. Once the containers are running, you can connect your debugger (e.g., Chrome DevTools, VS Code)
pnpm dev:debug #backend containers will not have hot reload feature enabled but will expose and have node `--inspect` option set with wallet container debug port set to 9229 and boutique port set to 9230. Once the containers are running, you can connect your debugger (e.g., Chrome DevTools, VS Code)
```

and:
Expand Down
13 changes: 7 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@
"clean": "pnpm clean:modules && pnpm clean:builds",
"clean:builds": "find . \\( -name \"dist\" -o -name \".next\" \\) -type d -prune -exec rm -rf '{}' +",
"clean:modules": "find . -name 'node_modules' -type d -prune -exec rm -rf '{}' +",
"dev": "pnpm localenv:start && concurrently -n 'WALLET,BOUTIQUE' -c blue.bold,red.bold 'pnpm wallet:frontend dev' 'pnpm boutique:frontend dev'",
"dev:debug": "pnpm localenv:start:debug && concurrently -n 'WALLET,BOUTIQUE' -c blue.bold,red.bold 'pnpm wallet:frontend dev' 'pnpm boutique:frontend dev'",
"dev:lite": "pnpm localenv:start:lite && concurrently -n 'WALLET,BOUTIQUE' -c blue.bold,red.bold 'pnpm wallet:frontend dev' 'pnpm boutique:frontend dev'",
"dev": "pnpm localenv:start && concurrently -n \"WALLET,BOUTIQUE\" -c blue.bold,red.bold \"pnpm wallet:frontend dev\" \"pnpm boutique:frontend dev\"",
"dev:debug": "pnpm localenv:start:debug && concurrently -n \"WALLET,BOUTIQUE\" -c blue.bold,red.bold \"pnpm wallet:frontend dev\" \"pnpm boutique:frontend dev\"",
"dev:lite": "pnpm localenv:start:lite && concurrently -n \"WALLET,BOUTIQUE\" -c blue.bold,red.bold \"pnpm wallet:frontend dev\" \"pnpm boutique:frontend dev\"",
"format": "pnpm prettier:write && pnpm lint:fix",
"lint:check": "eslint --max-warnings=0 .",
"lint:fix": "eslint --max-warnings=0 --fix .",
"compose": "docker compose -f ./docker/dev/docker-compose.yml",
"compose:prod": "docker compose -f ./docker/prod/docker-compose.yml",
"localenv:start": "DEV_MODE=hot-reload pnpm compose up -d --build",
"localenv:start:debug": "DEV_MODE=debug pnpm compose up -d --build",
"localenv:start:lite": "DEV_MODE=lite pnpm compose up -d --build",
"localenv:start": "cross-env DEV_MODE=hot-reload pnpm compose up -d --build",
"localenv:start:debug": "cross-env DEV_MODE=debug pnpm compose up -d --build",
"localenv:start:lite": "cross-env DEV_MODE=lite pnpm compose up -d --build",
"localenv:stop": "pnpm compose down",
"preinstall": "npx only-allow pnpm",
"prettier:write": "prettier --config '.prettierrc.js' --write .",
Expand All @@ -43,6 +43,7 @@
"@typescript-eslint/eslint-plugin": "^7.18.0",
"@typescript-eslint/parser": "^7.18.0",
"concurrently": "^9.0.1",
"cross-env": "^7.0.3",
"eslint": "^9.12.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-react": "^7.37.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/wallet/frontend/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@wallet/frontend",
"scripts": {
"dev": "PORT=4003 next dev",
"dev": "next dev -p 4003",
"build:deps": "pnpm --filter @wallet/shared build",
"build": "pnpm build:deps && next build",
"start": "next start"
Expand Down
12 changes: 12 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit d50071c

Please sign in to comment.