Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: windows compat issues with pnpm dev cmd & env var syntax #1743

Merged
merged 6 commits into from
Nov 5, 2024
Merged

fix: windows compat issues with pnpm dev cmd & env var syntax #1743

merged 6 commits into from
Nov 5, 2024

Conversation

DarianM
Copy link
Member

@DarianM DarianM commented Oct 16, 2024 •
edited
Loading

Context

Changes

  • change dev script in root package.json
  • changedev script in wallet frontend package.json

@DarianM DarianM added bug Something isn't working package: wallet/frontend Wallet frontend implementations labels Oct 16, 2024
@DarianM DarianM self-assigned this Oct 16, 2024
@DarianM DarianM linked an issue Oct 16, 2024 that may be closed by this pull request
[BUG] Fix local development windows environment #1738
Closed
@DarianM DarianM changed the title fix: windows compat issues with pnpm dev cmd and env var syntax fix: windows compat issues with pnpm dev cmd & env var syntax Oct 16, 2024
@DarianM DarianM removed their assignment Oct 16, 2024
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Nov 5, 2024
adrianboros
adrianboros previously approved these changes Nov 5, 2024
View reviewed changes
dragosp1011
dragosp1011 previously approved these changes Nov 5, 2024
View reviewed changes
@DarianM DarianM dismissed stale reviews from dragosp1011 and adrianboros via c7f177b November 5, 2024 13:19
@DarianM DarianM requested a review from adrianboros November 5, 2024 13:22
@DarianM DarianM marked this pull request as draft November 5, 2024 13:29
@DarianM DarianM marked this pull request as ready for review November 5, 2024 13:53
@DarianM DarianM requested a review from dragosp1011 November 5, 2024 13:54
@DarianM DarianM requested a review from Tymmmy November 5, 2024 13:56
@Tymmmy Tymmmy requested a review from sanducb November 5, 2024 13:59
@DarianM DarianM removed the request for review from Tymmmy November 5, 2024 14:02
@DarianM DarianM merged commit d50071c into main Nov 5, 2024
15 checks passed
@DarianM DarianM deleted the 1738-bug-local-dev-windows-env branch November 5, 2024 17:28
DarianM added a commit that referenced this pull request Nov 7, 2024
@DarianM
fix: windows compat issues with pnpm dev cmd & env var syntax (#1743)
1428330 
* fix win compat issues with pnpm dev cmd and env var syntax

* readme

* add cross-env

---------

Co-authored-by: darian <darian@interledger.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanducb sanducb sanducb approved these changes

@beniaminmunteanu beniaminmunteanu beniaminmunteanu approved these changes

@dragosp1011 dragosp1011 dragosp1011 approved these changes

@adrianboros adrianboros adrianboros approved these changes

@raducristianpopa raducristianpopa Awaiting requested review from raducristianpopa

@lengyel-arpad85 lengyel-arpad85 Awaiting requested review from lengyel-arpad85

Assignees
No one assigned
Labels
bug Something isn't working package: wallet/frontend Wallet frontend implementations type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Fix local development windows environment
5 participants
@DarianM @adrianboros @dragosp1011 @beniaminmunteanu @sanducb