feat(keyAutoAdd): support key addition for GateHub #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: content
Extension builds preview
|
){kind=icon}
){kind=icon}
sidvishnoi
force-pushed
the
gatehub-key-addition
branch
from
865b607 to
0169d1b
Compare
sidvishnoi
force-pushed
the
gatehub-key-addition
branch
from
0169d1b to
861c6f5
Compare
sidvishnoi
commented
Dec 13, 2024
Comment on lines
-65
to
+67
| width: '22rem', | ||
| height: '8rem', | ||
| width: '22em', | ||
| height: '8em', | ||
| fontSize: '16px', |
There was a problem hiding this comment.
GateHub has fontSize: 10px on root, so our notification UI had size reduced. This fixes it.
sidvishnoi
commented
Dec 13, 2024
| return json.data as R; | ||
| } | ||
|
|
||
| export class GraphQlError extends Error { |
There was a problem hiding this comment.
Just for us to distinguish between regular error and gql error and (if needed) get error info.
raducristianpopa
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #618
Changes proposed in this pull request
graphQlfetch request helper.