You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do not change any CSS, instead move any problematic styles on mobile into a media query scoped to desktop. Problematic style properties tend to be float, width and problems relating to the box-sizing model.
Any inline styles should be moved into a component or the legacy.less file.
Maintaining both v2 and v1 is becoming a bit of a burden
and resulting in various issues (such as analytics code which
expects a more modern version of jQuery).
I'm pretty confident at this point that we can deploy the
"nuclear" option and make v2 the default.
v2 boolean flags are left in tact as I'm not sure if they serve
any other purposes (for example in API requests)
"Mr President, it is not only possible, it is essential."
Dr Strangelove or: How I learned to stop worrying about making
Open Library mobile friendly
While this makes Open Library fully responsive, there are lots of
opportunities to improve the UI further in mobile.. there's a long
road ahead!
Untested but should also fix: internetarchive#1728internetarchive#1727Fixes: internetarchive#679
jdlrobson
added a commit
to jdlrobson/openlibrary
that referenced
this issue
Dec 15, 2018
Maintaining both v2 and v1 is becoming a bit of a burden
and resulting in various issues (such as analytics code which
expects a more modern version of jQuery).
I'm pretty confident at this point that we can deploy the
"nuclear" option and make v2 the default.
v2 boolean flags are left in tact as I'm not sure if they serve
any other purposes (for example in API requests)
"Mr President, it is not only possible, it is essential."
Dr Strangelove or: How I learned to stop worrying about making
Open Library mobile friendly
While this makes Open Library fully responsive, there are lots of
opportunities to improve the UI further in mobile.. there's a long
road ahead!
Untested but should also fix: internetarchive#1728internetarchive#1727Fixes: internetarchive#679
Bug
Visit https://openlibrary.org/data
on a mobile device. The page is not mobile optimised:
it should be limited to the viewport like the home page https://openlibrary.org
All mobile devices
To migrate a page do the following
Using the window.q handler
e.g.
becomes:
Here's an example for the subject page: 0abff2f
Optimising the page for mobile
Do not change any CSS, instead move any problematic styles on mobile into a media query scoped to desktop. Problematic style properties tend to be float, width and problems relating to the box-sizing model.
Any inline styles should be moved into a component or the legacy.less file.
Here's an example for the subject page:
0fd34b5
The text was updated successfully, but these errors were encountered: