semantic-ui: users: header: Use endpoints from config #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slint
reviewed
Nov 19, 2024
invenio_app_rdm/users_ui/templates/semantic-ui/invenio_app_rdm/users/header.html
Outdated
Show resolved
Hide resolved
sakshamarora1
force-pushed
the
fix/communties-new
branch
from
a5fc981 to
33ebdaf
Compare
zzacharo
approved these changes
Nov 19, 2024
slint
reviewed
Nov 21, 2024
| @@ -23,14 +23,14 @@ <h1 class="ui medium header" aria-label="{{ _('Your dashboard') }}">{{ current_u | |||
| </div> | |||
| </div> | |||
| {% if active_dashboard_menu_item == "uploads" %} | |||
| <a class="ui tiny button positive left labeled icon m-0" href="/uploads/new"> | |||
| <a class="ui tiny button positive left labeled icon m-0" href={{ url_for("deposit_create") }}> | |||
There was a problem hiding this comment.
@sakshamarora1 this should be actually invenio_app_rdm_records.deposit_create (since the blueprint has this prefix). This is also relevant to my comment about being explicit about the endpoint naming.
There was a problem hiding this comment.
is this working in flask/werkzeug <3.0.0 because with flask,werkzeug >3.0 it fails without the invenio_app_rdm_records prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: inveniosoftware/invenio-communities#1209