Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic-ui: users: header: Use endpoints from config #2911

Merged
merged 1 commit into from
Nov 19, 2024
Merged

semantic-ui: users: header: Use endpoints from config #2911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions invenio_app_rdm/users_ui/templates/semantic-ui/invenio_app_rdm/users/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ <h1 class="ui medium header" aria-label="{{ _('Your dashboard') }}">{{ current_u
</div>
</div>
{% if active_dashboard_menu_item == "uploads" %}
<a class="ui tiny button positive left labeled icon m-0" href="/uploads/new">
<a class="ui tiny button positive left labeled icon m-0" href={{ url_for("deposit_create") }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sakshamarora1 this should be actually invenio_app_rdm_records.deposit_create (since the blueprint has this prefix). This is also relevant to my comment about being explicit about the endpoint naming.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this working in flask/werkzeug <3.0.0 because with flask,werkzeug >3.0 it fails without the invenio_app_rdm_records prefix

<i class="upload icon" aria-hidden="true"></i>
{{ _('New upload') }}
</a>
{% endif %}

{% if active_dashboard_menu_item == "communities" %}
<a class="ui tiny button positive left labeled icon m-0" href="/communities/new">
<a class="ui tiny button positive left labeled icon m-0" href={{ url_for("communities_new") }}>
<i class="plus icon" aria-hidden="true"></i>
{{ _('New community') }}
</a>
Expand Down