-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run test in web browsers #300
Comments
The issues in IE are caused because Function.name is not an standard in JS versions < ES6. The good news is that function name is only used to provide developer-friendly errors and it will be fine to use the following:
Beyond this issue we need to prevent issues in browsers and to do so we need to run the tests on a web browser. |
The function.name issue was fixed #302 by but it has not been released yet. |
Hi @endel, Based on your feedback I have impelmented browser testing:
It is almost ready, all the integration tests are running on the latest version of IE, Chrome and Firefox on AppVeyor. There two test failing on IE 11 once I get those two sorted I will merge and close the issue. There might be problems in IE < 11 but I asume that everything can be fixed using polyfills. |
* Implemented #315 * Implemented #300 * Trying to fix 'Symbol' is undefined in AppVeyor * Trying to fix 'Promise' is undefined on IE AppVeyor * Fix 'undefined' as class name in error msgs when base class missing @Injectable annotation * Trying to fix symbol to string in node 0.12 * rollback * removed node 0.12 from testing will be not supported by october 2016
Done by #316 |
Yay! 🎉 👏 |
As reported by @endel there are some issues in some versions of IE we need to put in place some testing in real browsers to prevent this kind of issues.
At the moment we run the tests in bot windows and linux but in node.js not browser environments.
The text was updated successfully, but these errors were encountered: