Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed getFunctionName #301 #302

Merged
merged 1 commit into from
Jul 25, 2016
Merged

Fixed getFunctionName #301 #302

merged 1 commit into from
Jul 25, 2016

Conversation

mfrachet
Copy link
Contributor

I've modified this line and created a getFunctionName to factor a bit the declaration, and solving the due bug.

Description

I've created a function to factor the call on the line described, and write some tests (2) to fully cover the case.

Related Issue

Motivation and Context

  • Bug solving

How Has This Been Tested?

  • TDD
  • Writing a test that matches the first if case
  • Make it pass
  • Writing a test by failing the regex resolution
  • Make it pass
  • Creating a branch and push my code on this
  • Sending PR to Inversify

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the type definitions.
  • I have updated the type definitions accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

@Skahrz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @remojansen and @hourliert to be potential reviewers

@remojansen remojansen merged commit fd27686 into inversify:master Jul 25, 2016
This was referenced Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants