Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add mode agnostic css class #8545

Closed
alan-agius4 opened this issue Oct 6, 2016 · 2 comments
Closed

Proposal: Add mode agnostic css class #8545

alan-agius4 opened this issue Oct 6, 2016 · 2 comments
Assignees
Milestone

Comments

@alan-agius4
Copy link
Contributor

alan-agius4 commented Oct 6, 2016

We'd like to propose a bit of a change in the components base class. I kinda did a bit of a concept. And i am willing to go through all the components and implement this.

alan-agius4@5b3b5a2

basically at the moment for a component a class is added according to the mode set ex: .item-md, .item-wp, .item-md. However, if you'd like to override or add some for all modes it would be quite useful to have a mode agnostic class that you can target ex .item.

To be discussed with @adamdbradley and @brandyscarney.

@zakton5
Copy link
Contributor

zakton5 commented Oct 6, 2016

Agreed, I've had to adjust many styles because of mode-specific classes. As of now, it just causes us to make more CSS

@zakton5
Copy link
Contributor

zakton5 commented Oct 6, 2016

Related, most likely duplicate: #8533

@brandyscarney brandyscarney added this to the 2.0.0-rc.3 milestone Nov 10, 2016
@brandyscarney brandyscarney self-assigned this Nov 11, 2016
brandyscarney added a commit that referenced this issue Nov 14, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants