Feature/mode agnostic class #9133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-agius4/ionic into feature/mode-agnostic-class
manucorporat
approved these changes
Nov 14, 2016
|
@manucorporat any tips how I can do that? |
|
@alan-agius4 I can do it when I merge the PR. :) |
brandyscarney
pushed a commit
that referenced
this pull request
Nov 14, 2016
|
Merged it with this commit: 025c5cc. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Add a css class which is mode agnostic. So that developer can easily target a component when needed to change/add something non mode-specific
Changes proposed in this pull request:
modeinto thectorof the base classIonic Version: 2
Fixes: #8545