Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publish with retry method #455

Merged
merged 22 commits into from
Nov 23, 2021
Merged

Conversation

HenriqueNogara
Copy link
Contributor

@HenriqueNogara HenriqueNogara commented Oct 25, 2021

Description of change

Adds a method for promoting/reattaching messages sent to the tangle.

Links to any relevant issues

closes #426

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@HenriqueNogara HenriqueNogara marked this pull request as ready for review November 1, 2021 20:12
bindings/wasm/src/tangle/client.rs Outdated Show resolved Hide resolved
identity-iota/src/tangle/client.rs Outdated Show resolved Hide resolved
identity-iota/src/tangle/client.rs Show resolved Hide resolved
identity-iota/src/tangle/client.rs Show resolved Hide resolved
identity-iota/src/tangle/client.rs Outdated Show resolved Hide resolved
identity-iota/src/tangle/client.rs Outdated Show resolved Hide resolved
identity-iota/src/tangle/client.rs Outdated Show resolved Hide resolved
@cycraig cycraig changed the title add publish with retry method Add publish with retry method Nov 3, 2021
bindings/wasm/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@cycraig cycraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

bindings/wasm/Cargo.toml Outdated Show resolved Hide resolved
identity-iota/src/tangle/client.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Just some restructuring and not sure whether we need the new error. Other than that, looks good now!

identity-iota/src/tangle/client.rs Outdated Show resolved Hide resolved
@cycraig
Copy link
Contributor

cycraig commented Nov 23, 2021

The timeout for the Wasm examples/tests probably needs to be increased to account for the new confirmation delay on publishing.

defaultCommandTimeout: 180000, // 3 minutes to account for spurious network delays

jest.setTimeout(180000); // 3 minutes to account for spurious network delays, most tests pass in a few seconds

@HenriqueNogara HenriqueNogara merged commit 553d55b into dev Nov 23, 2021
@HenriqueNogara HenriqueNogara deleted the feat/promote-reattach-messages branch November 23, 2021 22:37
@cycraig cycraig added Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Added A new feature that requires a minor release. Part of "Added" section in changelog and removed Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog labels Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add Tangle Promotion / Reattach logic for IOTA Messages
4 participants