Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Use
mocha
instead ofjest
to execute the Node.js Wasm binding examples as tests.This replacement was necessary due to problems with
async
promises and timers when usingjest
, which became an issue for us after #455 since publishing now uses a timer to delay retry requests.This only affects the tests; the examples themselves run fine individually using Node.js directly.
Also updates the
package-lock.json
file to version 2 incidentally, since we're using Node 16 LTS as the minimum-supported version now.Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
Node.js and browser examples pass locally.
npm run build && npm run build:examples && npm run test:node && npm run test:browser
The examples workflow also succeeds: https://github.com/iotaledger/identity.rs/actions/runs/1503177178
Change checklist
Add an
x
to the boxes that are relevant to your changes.