Add iota-indexer RPC tests to CI #3781
Conversation
samuel-rufi
requested review from
msarcev,
alexsporn,
thibault-martinez,
DaughterOfMars,
fijter and
Dr-Electron
as code owners
|
This pull request has been deployed to Vercel. Latest commit: 99a5e8b ✅ Preview: https://apps-ui-nrmj9482z-iota1.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 99a5e8b ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-e7fg9a5xc.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 99a5e8b ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-e7euxuv0s.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 99a5e8b ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-ewzhqoi77.vercel.app |
.github/workflows/_rust_tests.yml
Outdated
| @@ -244,3 +244,4 @@ jobs: | |||
| cargo nextest run --no-fail-fast --test-threads 8 --package iota-graphql-e2e-tests --features pg_integration | |||
| cargo nextest run --no-fail-fast --test-threads 1 --package iota-cluster-test --test local_cluster_test --features pg_integration | |||
| cargo nextest run --no-fail-fast --test-threads 1 --package iota-indexer --test ingestion_tests --features pg_integration | |||
| cargo test --package iota-indexer --features shared_test_runtime | |||
There was a problem hiding this comment.
Is that not already covered by another job that would run all the tests?
There was a problem hiding this comment.
Hmm I couldn't find any relevant cargo test reference. Maybe @DaughterOfMars knows?
There was a problem hiding this comment.
That's true, it should be
There was a problem hiding this comment.
You mean this one?
iota/.github/workflows/codecov.yml
Line 58 in 210de2f
Couldn't find anything else.
There was a problem hiding this comment.
yeah because it runs with all features
There was a problem hiding this comment.
yeah because it runs with all features
Not sure what you meant by this.
Anyway, what I initially wanted to say is that the portion of test without the shared_test_runtime feature is now tested twice, in the usual Rust tests and in this new run.
There was a problem hiding this comment.
Is it this job that should run with all the features: https://github.com/iotaledger/iota/actions/runs/11597827866/job/32292483790?pr=3781 ?
As far as I see only indexer tests with no features are run there. Ingestion and rpc-tests are skipped.
Are you sure it works that way @DaughterOfMars ?
There was a problem hiding this comment.
First of all we need a running postgres instance for this run. Also the coverage run doesn't seem to run with all features as there is no feature flag specified. To avoid duplicate tests in this new run we can just specify/run the RPC tests with:
cargo test --profile simulator --package iota-indexer --features shared_test_runtime --test rpc-tests
There was a problem hiding this comment.
I was not speaking myself about the coverage job, just the usual rust tests job. And yeah I guess we would get rid of the duplicates by specifying which tests we want to run and not just the feature.
|
This pull request has been deployed to Vercel. Latest commit: 3524d1f ✅ Preview: https://apps-ui-m46mrrxl4-iota1.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 3524d1f ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-ev11yk0cb.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 3524d1f ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-fknllahel.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 3524d1f ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-ksipcs174.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: ea66c0d ✅ Preview: https://apps-ui-r5jeg4tit-iota1.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: ea66c0d ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-jjzoiwb2x.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: ea66c0d ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-5wnlsbt1a.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: ea66c0d ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-rmxwgqx4s.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: e05b801 ✅ Preview: https://apps-ui-d6dh7seni-iota1.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: e05b801 ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-at8kf304y.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: e05b801 ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-qmxtx5adw.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: e05b801 ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-qoet5fisi.vercel.app |
samuel-rufi
force-pushed
the
l1sc/infra/iota-indexer-ci-tests
branch
from
5a93665 to
c7e278e
Compare
|
This pull request has been deployed to Vercel. Latest commit: 5a93665 ✅ Preview: https://apps-ui-j2krl0hhn-iota1.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 5a93665 ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-d7rwmrwi6.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 5a93665 ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-fklrkotas.vercel.app |
samuel-rufi
force-pushed
the
l1sc/infra/iota-indexer-ci-tests
branch
from
c7e278e to
84bdce1
Compare
|
This pull request has been deployed to Vercel. Latest commit: c7e278e ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-620c041kf.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 84bdce1 ✅ Preview: https://apps-ui-hchhxnwjj-iota1.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 84bdce1 ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-lswtdi3sh.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 84bdce1 ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-exvawk6ie.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 84bdce1 ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-h43qnhrhf.vercel.app |
samuel-rufi
merged commit b6e4ad1
into
sc-platform/indexer-new-rpc-tests
Description of change
Adds
iota-indexerRPC tests to the CI.Links to any relevant issues
Fixes #3590
Type of change
How the change has been tested
I locally ran the required
cargo test --profile simulator --package iota-indexer --test rpc-tests --features shared_test_runtimecommand.Change checklist