This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 299
Assumptions about init-docs hashes #365
Labels
Comments
@lgierth yeah, some or the 'old' tests use the assumption that the repo is already populated with something. We just need to make it so that it uses the files.add call to populate the repo for the tests. |
ghost
mentioned this issue
Sep 28, 2016
@diasdavid @dignifiedquire any update here? |
@whyrusleeping I will take a look at this today |
Kind of related, maybe we should have a separate repository with test data we can use across the organization, with some json structure + files that we can use a central point for the data? Would be useful for existing projects + if people want to write new implementations in different languages/api connections |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I can't quite pin down what the issue is, but I think it's something about the assumptions js-ipfs-api makes about the init-docs hashes. My observations:
.refs
tests fail, while other tests seem to add the init-docs themselves and use the hash resulting from that.npm test
run works fine locally. Does js-ipfs-api use the go-ipfs from$PATH
? Does it generate ephemeral fs-repos? I do have the new init-docs in my~/.ipfs
fs-repo, and the tests might use that fs-repo in one spot and succeed because of that?I don't have a good idea but it's blocking ipfs/kubo#2997 which is a trivial PR in itself but turned into a yak shaving.
[1] http://ci.ipfs.team:8111/viewLog.html?buildId=5376&buildTypeId=GoIpfs_JsIpfsApiTests&tab=buildLog#_focus=1948
The text was updated successfully, but these errors were encountered: