Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Assumptions about init-docs hashes #365

Closed
ghost opened this issue Sep 1, 2016 · 4 comments
Closed

Assumptions about init-docs hashes #365

ghost opened this issue Sep 1, 2016 · 4 comments

Comments

@ghost
Copy link

ghost commented Sep 1, 2016

I can't quite pin down what the issue is, but I think it's something about the assumptions js-ipfs-api makes about the init-docs hashes. My observations:

  • I updated the init-docs in go-ipfs, and the js-ipfs build is failing. [1] It looks like only the .refs tests fail, while other tests seem to add the init-docs themselves and use the hash resulting from that.
  • The whole npm test run works fine locally. Does js-ipfs-api use the go-ipfs from $PATH? Does it generate ephemeral fs-repos? I do have the new init-docs in my ~/.ipfs fs-repo, and the tests might use that fs-repo in one spot and succeed because of that?

I don't have a good idea but it's blocking ipfs/kubo#2997 which is a trivial PR in itself but turned into a yak shaving.

[1] http://ci.ipfs.team:8111/viewLog.html?buildId=5376&buildTypeId=GoIpfs_JsIpfsApiTests&tab=buildLog#_focus=1948

@daviddias
Copy link
Contributor

daviddias commented Sep 6, 2016

@lgierth yeah, some or the 'old' tests use the assumption that the repo is already populated with something. We just need to make it so that it uses the files.add call to populate the repo for the tests.

@whyrusleeping
Copy link
Contributor

@diasdavid @dignifiedquire any update here?

@dignifiedquire
Copy link
Contributor

@whyrusleeping I will take a look at this today

@victorb
Copy link
Contributor

victorb commented Oct 1, 2016

Kind of related, maybe we should have a separate repository with test data we can use across the organization, with some json structure + files that we can use a central point for the data? Would be useful for existing projects + if people want to write new implementations in different languages/api connections

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants