This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
test: remove dependency on init doc hashes #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lgierth @whyrusleeping this should fix your ci issues |
daviddias
suggested changes
Sep 29, 2016
| expect(err).to.not.exist | ||
|
|
||
| expect(res).to.have.a.property('Objects') | ||
| expect(res.Objects[0]).to.have.a.property('Links') | ||
| expect(res.Objects[0]).to.have.property('Hash', 'QmYwAPJzv5CZsnA625s3Xf2nemtYgPpHdWEz79ojWnPbdG') | ||
| expect(res.Objects[0]).to.have.property('Hash') |
There was a problem hiding this comment.
the hash value is not being checked anymore.
| ipfs.util.addFromFs(filesPath, { recursive: true }, cb) | ||
| }, | ||
| (hashes, cb) => { | ||
| folderHash = hashes[hashes.length - 1].hash |
There was a problem hiding this comment.
Although we should use the value returned to make sure we are fetching the correct one, we should also have the expected hash hard coded, we've captured bugs in the past because the browser was adding different stuff then what it was added in Node.js
| .then((res) => { | ||
| expect(res).to.have.a.property('Objects') | ||
| expect(res.Objects[0]).to.have.a.property('Links') | ||
| expect(res.Objects[0]).to.have.property('Hash', 'QmYwAPJzv5CZsnA625s3Xf2nemtYgPpHdWEz79ojWnPbdG') | ||
| expect(res.Objects[0]).to.have.property('Hash') |
| @@ -57,13 +67,11 @@ describe('ls', function () { | |||
|
|
|||
| describe('promise', () => { | |||
| it('should correctly retrieve links', () => { | |||
| if (!isNode) return | |||
There was a problem hiding this comment.
This works all in the browser now? Sweet!
There was a problem hiding this comment.
no, I just moved the isNode check to the top of the test
daviddias
approved these changes
Sep 29, 2016
|
thanks <3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #365