Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

reduce size of ipfs.add bundle and number of RPC requests. #522

Closed
slothbag opened this issue Feb 10, 2017 · 5 comments
Closed

reduce size of ipfs.add bundle and number of RPC requests. #522

slothbag opened this issue Feb 10, 2017 · 5 comments
Labels
difficulty:moderate P0 - Critical ready

Comments

@slothbag
Copy link

It appears the first request is to add the content, which we get a hash value returned. But then it makes two more requests to get the data and links back.

Is there are a way to disable the last 2 requests? I only need the hash.

Cheers
@daviddias
Copy link
Contributor

@slothbag I believe it only issues 2 requests, correct?

We could skip the second one if this ipfs/kubo#4008 comes to happen.

Now that #561 is happening, we will see a ton of bundle size reduction for ipfs-api/add if we can avoid that extra RTT

@daviddias daviddias changed the title ipfs.Add creates 3 RPC requests reduce size of ipfs.add bundle and number of RPC requests. Jun 27, 2017
This was referenced Aug 17, 2017
Closed
Closed
@daviddias
Copy link
Contributor

daviddias commented Sep 6, 2017 •
edited
Loading

Now that ipfs/kubo#4082 has been merged and released, we can finish this up. (and also that ipfsd-ctl was updated)

Update: Actually, This -- ipfs/js-ipfsd-ctl#165 -- needs to happen before I can release a new version of ipfsd-ctl and test latest go-ipfs here with confidence :)

@daviddias daviddias mentioned this issue Sep 6, 2017
Open
@daviddias
Copy link
Contributor

Now that the Dragon is gone (once released) ipfs/js-ipfsd-ctl#165 (comment) I'll be able to PR for this issue in this issue :)

daviddias added a commit that referenced this issue Sep 6, 2017
@daviddias
feat: avoid doing multiple RPC requests for files.add, fixes #522
0e85b16
@daviddias daviddias mentioned this issue Sep 6, 2017
Merged
@daviddias
Copy link
Contributor

Seems that I was wrong, the feature required in go-ipfs is only going to be released in 0.4.11. Nevertheless, I went ahead and developed the PR for it once it gets released -> #595

Closing this one, let's track on the PR itself #595

daviddias added a commit that referenced this issue Oct 18, 2017
@daviddias
feat: avoid doing multiple RPC requests for files.add, fixes #522
9c34172
daviddias added a commit that referenced this issue Oct 18, 2017
@daviddias
feat: avoid doing multiple RPC requests for files.add, fixes #522 (#595)
0ea5f57 
* chore: test against go-ipfs 0.4.11

* feat: avoid doing multiple RPC requests for files.add, fixes #522

* new bundle sizes, so much space saved!

* use converter

* add progress tracking back
@daviddias
Copy link
Contributor

Released with v14.3.7 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
difficulty:moderate P0 - Critical ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slothbag @daviddias