ipfs add: added size to response of ipfs add command
#4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes: #4008 |
The `ipfs add` command was modified to include the added node's size as a string. The size is included in the dagnode info sent over the output channel. License: MIT Signed-off-by: Tom O'Donnell <todonnel91@gmail.com>
te0d
force-pushed
the
feat/commands/add-size
branch
from
923797e
to
0a01ffb
Compare
|
|
|
Would https://gist.github.com/te0d/fcdfc0d1578fc3bcb7d1fed36c2a260b meet testing needs? Is the test in the appropriate location (../test/sharness/t0410-api-add.sh)? |
|
@te0d I'd at least like to make sure we verify the value thats returned is correct, but yeah, thats pretty much what i'm hoping for |
te0d
force-pushed
the
feat/commands/add-size
branch
from
d558881
to
5b74496
Compare
Added test case which greps the `ipfs add` api call, checking that it outputs the added item's size. License: MIT Signed-off-by: Tom O'Donnell <todonnell91@gmail.com>
te0d
force-pushed
the
feat/commands/add-size
branch
from
5b74496
to
f96f6af
Compare
daviddias
approved these changes
Jul 29, 2017
|
wooooot! 🚀 |
sorki
added a commit
to sorki/blockfrost-openapi
that referenced
this pull request
Aug 13, 2021
ipfs/kubo#4008 (comment) Also the decription is changed as it returns resulting IPFS node size according to ipfs/kubo#4082
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ipfs addcommand was modified to include the addednode's size as a string. The size is included in the
dagnode info sent over the output channel.
License: MIT
Signed-off-by: Tom O'Donnell todonnel91@gmail.com