This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
feat: return protocol from getEndpointConfig #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protocol is used to construct the request, and it's useful to be able to check it has been set correctly, so we add it here to he the util.getEndpointConfig() return value. License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
ghost
assigned
olizilla
added a commit
to ipfs-inactive/ipfs-redux-bundle
that referenced
this pull request
Jan 25, 2019
Depends on - multiformats/js-uri-to-multiaddr#3 - ipfs-inactive/js-ipfs-http-client#935 Fixes ipfs/ipfs-webui#925 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
This was referenced Jan 25, 2019
olizilla
added a commit
that referenced
this pull request
Jan 28, 2019
- ensure explicitly passed parameters are used; dont pass in the default values and assume the are being set correctly TODO: needs #935 to expose the protocol and api-path properties License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
|
I have added See: #934 (comment) |
alanshaw
approved these changes
Jan 28, 2019
|
LGTM - macos failures seem unrelated |
olizilla
added a commit
to ipfs-inactive/ipfs-redux-bundle
that referenced
this pull request
Feb 18, 2019
You have to explicitly pass the protocol to the ipfs-http-client constructor Depends on - multiformats/js-uri-to-multiaddr#3 - ipfs-inactive/js-ipfs-http-client#935 Fixes ipfs/ipfs-webui#925 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protocol is used to construct the request, and it's useful to be able to check it has been set correctly. This PR adds it to the
util.getEndpointConfig()return value.License: MIT
Signed-off-by: Oli Evans oli@tableflip.io