fix: add default port for protocol #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiaddrs are more explicit than urls. Default ports should always be included. License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
olizilla
changed the title
olizilla
added a commit
to ipfs-inactive/ipfs-redux-bundle
that referenced
this pull request
Jan 25, 2019
Depends on - multiformats/js-uri-to-multiaddr#3 - ipfs-inactive/js-ipfs-http-client#935 Fixes ipfs/ipfs-webui#925 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
This was referenced Jan 25, 2019
lidel
requested changes
Jan 25, 2019
index.js
Outdated
| * https://foobar.com => /dns4/foobar.com/tcp/443/tls/http | ||
| * https://foobar.com:5001 => /dns4/foobar.com/tcp/5001/tls/http | ||
| * https://127.0.0.1:8080 => /ip4/127.0.0.1/tcp/8080/tls/http | ||
| * http://[::0]:8080 => /ip6/::0/tcp/8080/http |
There was a problem hiding this comment.
Why tho 🤔 For ip4 (1 line above) we default to localhost, shouldn't we do the same here? (::1)
I know this is a nit, but there is a huge difference if a beginner just copies&pastes 0.0.0.0:5001 vs 127.0.0.1:5001 without thinking, so I always try to avoid "listen on all interfaces" in examples :)
| @@ -3,8 +3,8 @@ const toMultiaddr = require('./') | |||
|
|
|||
| test('should convert URIs to multiaddrs', (t) => { | |||
| const data = [ | |||
| ['/ip4/127.0.0.1/http', 'http://127.0.0.1'], | |||
| ['/ip6/fc00::/http', 'http://[fc00::]'], | |||
| ['/ip4/127.0.0.1/tcp/80/http', 'http://127.0.0.1'], | |||
There was a problem hiding this comment.
Perhaps we should keep tests for both versions?
There was a problem hiding this comment.
You mean ip4 and ip6? Both tests have been kept, I just updated to include the port. Pesky diff.
Co-Authored-By: olizilla <oli@tableflip.io>
olizilla
commented
Jan 29, 2019
olizilla
added a commit
to ipfs-inactive/ipfs-redux-bundle
that referenced
this pull request
Feb 18, 2019
You have to explicitly pass the protocol to the ipfs-http-client constructor Depends on - multiformats/js-uri-to-multiaddr#3 - ipfs-inactive/js-ipfs-http-client#935 Fixes ipfs/ipfs-webui#925 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiaddrs are more explicit than urls. Default ports should always be included.
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io