Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lookup pretty #3

Merged
merged 4 commits into from
Oct 21, 2015
Merged

Lookup pretty #3

merged 4 commits into from
Oct 21, 2015

Conversation

dignifiedquire
Copy link
Member

  • Fix linting
  • Update devDependencies
  • Add lookupPretty
  • Improve docs
  • Improve code organization

Ref ipfs/js-ipfsd-ctl#18

jbenet
jbenet reviewed Oct 18, 2015
View reviewed changes
lib/format.js
if (data[7]) obj.metro_code = data[7]
if (data[8]) obj.area_code = data[8]

obj.planet = PLANET
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@jbenet
Copy link

jbenet commented Oct 18, 2015

this LGTM, though i haven't checked the js code

@krl
Copy link
Contributor

krl commented Oct 19, 2015

Looking good!

@dignifiedquire dignifiedquire mentioned this pull request Oct 19, 2015
Closed
62 tasks
@dignifiedquire
Copy link
Member Author

@krl feel free to merge when you like it

@daviddias
Copy link
Member

Merging it :)

daviddias added a commit that referenced this pull request Oct 21, 2015
@daviddias
Merge pull request #3 from Dignifiedquire/lookup-pretty
3a74755 
Lookup pretty
@daviddias daviddias merged commit 3a74755 into ipfs-shipyard:master Oct 21, 2015
@daviddias
Copy link
Member

@jbenet @krl when you can, can you publish it to npm? (or give me perm, happy to do it)

@dignifiedquire dignifiedquire deleted the lookup-pretty branch October 21, 2015 22:47
@jbenet
Copy link

jbenet commented Oct 27, 2015

@diasdavid should be owner now.

@daviddias
Copy link
Member

thanks @jbenet

@dignifiedquire published https://www.npmjs.com/package/ipfs-geoip :)

@dignifiedquire
Copy link
Member Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dignifiedquire @jbenet @krl @daviddias