-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need stats reports for electron-app #18
Comments
For "Local storage size" and "Object count" we could add an For "Location" -- can use the local node's addresses, and geocode them the same way the peers are. |
I've pulled https://github.com/Dignifiedquire/electron-app/blob/settings-hot/app/helpers.js from the webui into the electron-app. So the question is where to best have this code to avoid this duplication, maybe it makes sense to have it in here, or just as a format function of https://github.com/krl/ipfs-geoip. Thoughts? |
yeah probably makes sense to put in geoip. also -- https://github.com/Dignifiedquire/electron-app/blob/settings-hot/app/helpers.js#L1 is that ES6? or what? are we compiling into regular js for now, or what's the goal? |
@krl would you mind moving ipfs-geoip into |
This adds the formatted property which is used in ipfs/webui and ipfs/station. Ref ipfs/js-ipfsd-ctl#18
Seems that Location is done https://github.com/ipfs/ipfs-geoip , ^5 to @dignifiedquire For the other two, @whyrusleeping what you think of adding those as CLI commands and exposing them through the http API as well? |
local storage size is implemented in a PR by @rht (ipfs/kubo#1495) but i dont think its exposed via command line quite yet. object count can be retrieved naively by piping |
Sounds good, we can use the node-ipfs-api to fetch that info :) //cc @dignifiedquire |
counting internal to the node would avoid piping a ton of data out. wonder if we should keep these counts in a repo object somewhere, cached and recomputed every once in a while. |
It would be great to have the following data exposed to display them as stats:
The text was updated successfully, but these errors were encountered: