Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need stats reports for electron-app #18

Closed
3 tasks done
dignifiedquire opened this issue Sep 22, 2015 · 8 comments
Closed
3 tasks done

Need stats reports for electron-app #18

dignifiedquire opened this issue Sep 22, 2015 · 8 comments
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature

Comments

@dignifiedquire
Copy link
Member

It would be great to have the following data exposed to display them as stats:

  • Local storage size
  • Object count
  • Location
@jbenet
Copy link
Member

jbenet commented Sep 23, 2015

For "Local storage size" and "Object count" we could add an ipfs repo stat command to go-ipfs.

For "Location" -- can use the local node's addresses, and geocode them the same way the peers are.

@dignifiedquire
Copy link
Member Author

I've pulled https://github.com/Dignifiedquire/electron-app/blob/settings-hot/app/helpers.js from the webui into the electron-app. So the question is where to best have this code to avoid this duplication, maybe it makes sense to have it in here, or just as a format function of https://github.com/krl/ipfs-geoip. Thoughts?

@jbenet
Copy link
Member

jbenet commented Sep 27, 2015

yeah probably makes sense to put in geoip.

also -- https://github.com/Dignifiedquire/electron-app/blob/settings-hot/app/helpers.js#L1 is that ES6? or what? are we compiling into regular js for now, or what's the goal?

@jbenet
Copy link
Member

jbenet commented Sep 27, 2015

@krl would you mind moving ipfs-geoip into ipfs/ org? or do you want to keep maintaining it? either way is fine but we probably will need to fork it to ipfs org to ensure it survives and gets long term maintained, etc

dignifiedquire added a commit to dignifiedquire/ipfs-geoip that referenced this issue Oct 17, 2015
This adds the formatted property which is used
in ipfs/webui and ipfs/station.

Ref ipfs/js-ipfsd-ctl#18
@daviddias daviddias added the help wanted Seeking public contribution on this issue label Oct 21, 2015
@daviddias
Copy link
Member

Seems that Location is done https://github.com/ipfs/ipfs-geoip , ^5 to @dignifiedquire

For the other two, @whyrusleeping what you think of adding those as CLI commands and exposing them through the http API as well?

@whyrusleeping
Copy link
Member

local storage size is implemented in a PR by @rht (ipfs/kubo#1495) but i dont think its exposed via command line quite yet.

object count can be retrieved naively by piping ipfs refs local to wc. And any command we write for getting that number will do the same under the hood.

@daviddias
Copy link
Member

object count can be retrieved naively by piping ipfs refs local to wc. And any command we write for getting that number will do the same under the hood.

Sounds good, we can use the node-ipfs-api to fetch that info :) //cc @dignifiedquire

@jbenet
Copy link
Member

jbenet commented Oct 27, 2015

object count can be retrieved naively by piping ipfs refs local to wc. And any command we write for getting that number will do the same under the hood.

counting internal to the node would avoid piping a ton of data out.

wonder if we should keep these counts in a repo object somewhere, cached and recomputed every once in a while.

@daviddias daviddias added the kind/enhancement A net-new feature or improvement to an existing feature label Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants