Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint commit messages before pushing #59

Closed
victorb opened this issue Sep 22, 2016 · 3 comments
Closed

Lint commit messages before pushing #59

victorb opened this issue Sep 22, 2016 · 3 comments
Assignees
@achingbrain @hacdias
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up

Comments

@victorb
Copy link
Member

victorb commented Sep 22, 2016

Would be effective if we could really get into the habit of writing git commit msgs that conforms to our standard.

One way of enforcing this could be to look through the commits pre-push, to make sure that they match our expectations.

Could also run in a post-commit hook I guess.

Related: #30
@victorb victorb mentioned this issue Sep 22, 2016
Merged
@daviddias daviddias added the status/ready Ready to be worked label Dec 5, 2016
@daviddias daviddias added status/deferred Conscious decision to pause or backlog and removed status/ready Ready to be worked labels Jan 29, 2017
@daviddias daviddias added status/ready Ready to be worked exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up and removed status/deferred Conscious decision to pause or backlog labels Oct 17, 2017
@hacdias
Copy link
Member

hacdias commented Jan 12, 2018

Do we still want to do this @diasdavid?

@daviddias
Copy link
Member

Yes please!!!

@hacdias hacdias mentioned this issue Jan 12, 2018
Closed
@hacdias hacdias self-assigned this Jan 12, 2018
@victorb victorb mentioned this issue May 8, 2018
Merged
@ghost ghost removed the status/ready Ready to be worked label May 8, 2018
@achingbrain
Copy link
Member

This should be runnable without having to push to Jenkins first. I've added this npm script to js-ipfs-mfs for this purpose but it should really be part of aegir.

If we're going to start removing hooks in favour of CI then we can limit developer surprise by letting them run all the same checks locally as on Jenkins...

@achingbrain achingbrain reopened this Jun 28, 2018
@achingbrain achingbrain mentioned this issue Jun 28, 2018
Merged
@ghost ghost assigned achingbrain Jun 28, 2018
@ghost ghost added the status/in-progress In progress label Jun 28, 2018
@ghost ghost removed the status/in-progress In progress label Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achingbrain achingbrain

@hacdias hacdias

Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@victorb @achingbrain @daviddias @hacdias