Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lint commit messages #245

Merged
merged 2 commits into from
Jul 5, 2018
Merged

feat: lint commit messages #245

merged 2 commits into from
Jul 5, 2018

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Jun 28, 2018

Will lint all commit messages between remotes/origin/master and HEAD using @commitlint/config-conventional.

To lint between different commits use:

$ aegir lint-commits --from $COMMITISH --to $COMMITISH

This should be set up as a pre-push or post-commit hook as regular linting runs pre-commit so the messages we want to examine won't be in the history yet..

Fixes #59

@ghost ghost assigned achingbrain Jun 28, 2018
@ghost ghost added the status/in-progress In progress label Jun 28, 2018
@achingbrain achingbrain force-pushed the lint-commit-messages branch 9 times, most recently from c2cb292 to a972f68 Compare June 28, 2018 15:16
Will lint between remotes/origin/master and HEAD.

To lint between different commits use:

```sh
$ aegir lint-commits  --from $COMMITISH --to $COMMITISH
```

This should be set up as a pre-push or post-commit hook as regular
linting runs pre-commit so the messages we want to examine won't
be in the history yet..
@achingbrain achingbrain force-pushed the lint-commit-messages branch from a972f68 to 0597098 Compare June 28, 2018 15:22
@achingbrain achingbrain requested review from victorb and daviddias June 28, 2018 18:20
@ghost ghost assigned victorb Jul 5, 2018
@victorb victorb merged commit e3e183a into master Jul 5, 2018
@ghost ghost removed the status/in-progress In progress label Jul 5, 2018
@daviddias daviddias deleted the lint-commit-messages branch July 5, 2018 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants