Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Add blob-stores to deps instead of devDeps #502

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

victorb
Copy link
Member

@victorb victorb commented Sep 17, 2016

We depend on these in the application and they are needed to run

const Store = require('fs-pull-blob-store')

const Store = require('fs-pull-blob-store')

const Store = require('idb-pull-blob-store')

@victorb victorb added the status/in-progress In progress label Sep 17, 2016
@dignifiedquire
Copy link
Member

thanks :) can you please change the commit message to follow our convention? sth like fix(deps): move blob stores to dependencies

@victorb
Copy link
Member Author

victorb commented Sep 17, 2016

@dignifiedquire ah, of course! Forgot... We should have a post-commit lint for that!

@victorb victorb force-pushed the add-blob-stores-to-deps branch from 4913018 to da205f8 Compare September 17, 2016 15:54
@victorb
Copy link
Member Author

victorb commented Sep 17, 2016

@dignifiedquire commit msg fixed!

@dignifiedquire
Copy link
Member

lgtm

@dignifiedquire dignifiedquire self-assigned this Sep 19, 2016
@dignifiedquire
Copy link
Member

Sorry @victorbjelkholm could you rebase onto master please, seems there is a merge conflict

@daviddias
Copy link
Member

@victorbjelkholm can you add this -- #502 (comment) -- as a feature request for aegir?

We depend on these in the application and they are needed to run
@victorb victorb force-pushed the add-blob-stores-to-deps branch from da205f8 to 8f33d11 Compare September 22, 2016 14:50
@victorb
Copy link
Member Author

victorb commented Sep 22, 2016

@dignifiedquire rebased! \o/

@diasdavid Opened! ipfs/aegir#59

@daviddias daviddias merged commit 5d82ee3 into ipfs:master Sep 22, 2016
@daviddias daviddias removed the status/in-progress In progress label Sep 22, 2016
@daviddias
Copy link
Member

thank you @victorbjelkholm :)

@victorb victorb deleted the add-blob-stores-to-deps branch October 6, 2017 09:41
MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this pull request May 22, 2020
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants