-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to choose the script to run to test dependent #882
feat: add option to choose the script to run to test dependent #882
Conversation
oliveriosousa
commented
Aug 24, 2021
•
edited
Loading
edited
- Adds an option to test dependent to choose the script to run (default -> test)
This is necessary because the repos in the I'm not against this change, but why not just use |
Hi @achingbrain, Yes, some examples, e.g.: react, vue, nextjs, have their proper test scripts. If someone wants to use the standalone repo from, for example, vue, to create an app the only step the user needs to "clean" the repo is removing the |
I think they'll need to do a bit more as it stands so I'm not sure it's that simple. For example |
If the idea is that you'd use the Since they don't currently, I'd propose that as a further work item, rename |
I've already made the suggested changes, I'm just waiting for this PR ipfs-examples/js-ipfs-examples#26 to have the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Can you please add a test to ensure there are no regressions around this feature, then this is ready to go.
Will do, thanks @achingbrain |