-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: move examples to external repo #3821
chore: move examples to external repo #3821
Conversation
8ec7aa8
to
7ab2ece
Compare
Could you please also:
|
Also, it'd be nice to test the examples individually as it's the longest build step by far so good to break it into chunks. |
2fa3c21
to
6bf176d
Compare
It'd be great to get this merged. I think the last thing to do is to test the examples individually. By which I mean instead of: - stage: test
name: examples
script:
# Travis lets scripts continue even if previous steps fail so need to use &&: https://github.com/travis-ci/travis-ci/issues/1066
- npm run configure-examples &&
npm run test -- $RUN_SINCE --scope=example* --concurrency=1 Do: - stage: test
name: examples - ipfs-http-client upload file
script:
- npm run test:external -- -- -- https://github.com/ipfs-examples/js-ipfs-http-client-upload-file.git
- stage: test
name: examples - ipfs-http-client bundle webpack
script:
- npm run test:external -- -- -- https://github.com/ipfs-examples/js-ipfs-http-client-bundle-webpack.git
- stage: test
name: examples - ipfs browser webpack
script:
- npm run test:external -- -- -- https://github.com/ipfs-examples/js-ipfs-browser-webpack.git
// etc ..so that all the example tests run in parallel. It looks like the repos under They also appear to use the |
Hi @achingbrain, Thanks for the explanation but it raises some concerns. Can we make this improvement of having tests running in parallel done in the other repo? |
6bf176d
to
d7557a0
Compare
This is true, but are you expecting a large amount of churn in the number of examples to be added over time? If not, adding new entries may not be a huge burden. Furthermore adding examples to the the
This will still run in a single travis runner though, right? Historically they've been too weak to do things like run multiple browser based tests simultaneously. |
e9e300d
to
36ad4bd
Compare
- Removes all the examples from this repository - Change CI to execute the test examples from external repo (https://github.com/ipfs-examples/js-ipfs-examples.git) - Update `.md` files and add links to point to the new examples org/repos - Remove scripts related with example tests
UPDATE:
.md
files and add links to point to the new examples org/reposCC @hugomrdias @achingbrain