Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Add support to run tests in web workers #94

Merged
merged 5 commits into from
Jan 26, 2017
Merged

POC: Add support to run tests in web workers #94

merged 5 commits into from
Jan 26, 2017

Conversation

dryajov
Copy link
Member

@dryajov dryajov commented Jan 23, 2017

This is a POC to add support for running tests in webworkers. I'm using this karma plugin - https://github.com/Joris-van-der-Wel/karma-mocha-webworker, it seems to get the job done and it allows running all tests inside a webworker. @dignifiedquire @diasdavid please let me know what you think.

Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, some small things

  • Can you remove the version bump things, I generate them when I publish to npm
  • the release task also needs to take the webworker option, so that the tests are included when testing before release.

@dryajov
Copy link
Member Author

dryajov commented Jan 23, 2017

I'll try to get to this ASAP, hopping for today.

@dryajov
Copy link
Member Author

dryajov commented Jan 24, 2017

@dignifiedquire I've made the changes you requested, let me know if something else is missing.

@dignifiedquire dignifiedquire merged commit 0b7a851 into ipfs:master Jan 26, 2017
@dignifiedquire dignifiedquire removed the status/deferred Conscious decision to pause or backlog label Jan 26, 2017
@dignifiedquire
Copy link
Member

@dryajov I just saw that the karma.webworker.conf file is missing, could you open a PR adding that, so I can release this?

@dryajov
Copy link
Member Author

dryajov commented Jan 26, 2017

Ah... Will do ASAP. @dignifiedquire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants