"Support for WebWorker." Fixing missing self definition which fails linting #61
Conversation
Signed-off-by: Tom Swindell <t.swindell@rubyx.co.uk>
|
@diasdavid @dignifiedquire Could we merge this in? I'd love to get this in master so we can get it running in ServiceWorkers. |
dryajov
changed the title
There was a problem hiding this comment.
Can we get a test for the browser that checks it is available within a WebWorker?
(my previous comment: #59 (comment))
|
It seems like it would be better adding WebWorker tests to all the js projects... Its possible to do that with a karma plugin like this one - https://github.com/Joris-van-der-Wel/karma-mocha-webworker. I can bolt it as a one off to this project, but it'd be a hack. Not sure how you guys go about making this sort of decisions, but I'd be happy to help with anything I can. I've got a PR (ipfs/aegir#94) in aegir that addresses this issue. It's a POC, but seems to work as intended on this project at least. |
|
@dryajov thank you, lets get the aegir PR shipped and then we can ship this. |
|
@diasdavid @dignifiedquire Can we get this PR merged - ipfs/aegir#94 (unless there is something else outstanding) so we can merge this changes in? Also, we should be able to move the rest of the projects to running tests in WebWorkers once that's in, not sure how you want to track that effort. |
|
Thanks, will run this through in the morning and hopefully ship then. Let's open an issue on ipfs/js-ipfs for tracking. |
| "Yusef Napora <yusef@napora.org>", | ||
| "dryajov <dryajov@gmail.com>", |
There was a problem hiding this comment.
Can you drop these two contributor additions, they are auto generated on release
| "test:node": "aegir-test --env node", | ||
| "test:no-webcrypto": "NO_WEBCRYPTO=true aegir-test --env node", | ||
| "test:browser": "aegir-test --env browser", | ||
| "test:webworker": "aegir-test --env webworker", |
There was a problem hiding this comment.
Need the --env webworker for the releases as well
There was a problem hiding this comment.
Is that needed? Looking at aegir, the tests tasks already get invoked on release and I've added the test:webworker task there.
|
Moved to #63 |
dignifiedquire
removed
the
status/deferred
|
Just released :) |
This fixes linting issues in PR #59