-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat(test): enable tests in webworkers by default #98
Conversation
Thank you, will ship once I ran it through a couple of tests |
@dignifiedquire I found a bug in this PR, and will be updating it today. Can we leave this for now and mark it as WIP? Thanks! |
Sure thing, thanks |
@dignifiedquire made files and frameworks config entries for |
Lgtm @dryajov is this ready now? |
@dignifiedquire It should be. My only concern is that releasing this will break projects that fail under WW tests, until this PRs are merged:
But this are failing on lint because of missing One solution would be to release this as a major version, and then upgrade the rest of the projects once those PRs are merged int. The ones that are failing on a missing Let me know how you want to proceed with this. I just don't want to leave things in a broken state and this will, until the rest of the PRs are merged in. |
I should clarify that, the |
I will make this a major version bump anyway, so we can upgrade the dependencies one by one once they are ready, without breaking them. That way we don't have to add the global comments in there. |
published v10 |
awesome 🎈 |
No description provided.