This repository has been archived by the owner on Aug 24, 2021. It is now read-only.
feat: change window to self for webworker support #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dryajov
changed the title
dignifiedquire
suggested changes
Feb 8, 2017
| @@ -44,7 +44,7 @@ | |||
| "nodeify": "^1.0.0" | |||
| }, | |||
| "devDependencies": { | |||
| "aegir": "^9.4.0", | |||
| "aegir": "^10.0.0", | |||
There was a problem hiding this comment.
Can you remove the --webworker flags in the scripts please, as they are not needed anymore
dignifiedquire
approved these changes
Feb 8, 2017
|
@diasdavid @dignifiedquire can we get this merged and released? This is probably the dependency that will make most others fail once aegir is bumped to v10. |
|
Yes, lets ship this, was just waiting for CI to be happy :) |
|
awesome! 🎈 Is this released also? |
|
yes, just shipped 0.4.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full WebWorker compatibility ipfs/js-ipfs#725