Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockservice: optimize getBlocks filter by not rescanning the already valid leading elements #558

Merged
1 commit merged into from
Jan 15, 2024

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jan 15, 2024

We would scan the valid leading elements twice.

… valid leading elements

We would scan the valid leading elements twice.
@Jorropo Jorropo requested a review from a team as a code owner January 15, 2024 12:14
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7f33e6) 65.45% compared to head (d5be896) 65.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
- Coverage   65.45%   65.45%   -0.01%     
==========================================
  Files         207      207              
  Lines       25622    25623       +1     
==========================================
  Hits        16772    16772              
- Misses       7369     7371       +2     
+ Partials     1481     1480       -1     
Files Coverage Δ
blockservice/blockservice.go 78.37% <100.00%> (+3.12%) ⬆️

... and 10 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants