Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockservice: stop using deprecated NewWriteThrough in tests #560

Merged

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jan 15, 2024

No description provided.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02c77b4) 65.41% compared to head (b8ac21b) 65.16%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           blockservice-docs     #560      +/-   ##
=====================================================
- Coverage              65.41%   65.16%   -0.25%     
=====================================================
  Files                    204      204              
  Lines                  25552    25597      +45     
=====================================================
- Hits                   16715    16681      -34     
- Misses                  7357     7433      +76     
- Partials                1480     1483       +3     

see 22 files with indirect coverage changes

Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering it has been deprecated in a previous major release, I think it's fine to finally remove it.

Base automatically changed from blockservice-docs to blockservice-opt January 15, 2024 17:19
@Jorropo Jorropo merged commit 0302f69 into blockservice-opt Jan 15, 2024
14 of 22 checks passed
@Jorropo Jorropo deleted the blockservice-stop-using-NewWriteThrough-in-tests branch January 15, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants