generated from ipfs/ipfs-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bitswap/client): add additional tracing #615
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
commented
Jun 7, 2024
aschmahmann
force-pushed
the
feat/more-bitswap-tracing
branch
from
June 7, 2024 21:04
2edcb50
to
3681ae1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #615 +/- ##
=======================================
Coverage 59.77% 59.77%
=======================================
Files 238 238
Lines 29943 29979 +36
=======================================
+ Hits 17898 17920 +22
- Misses 10429 10439 +10
- Partials 1616 1620 +4
|
aschmahmann
force-pushed
the
feat/more-bitswap-tracing
branch
from
June 17, 2024 13:25
3681ae1
to
6026b54
Compare
aschmahmann
commented
Jun 17, 2024
aschmahmann
force-pushed
the
feat/more-bitswap-tracing
branch
from
June 17, 2024 13:30
6026b54
to
fa5aaca
Compare
gammazero
reviewed
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment, LGTM
gammazero
approved these changes
Jun 19, 2024
aschmahmann
force-pushed
the
feat/more-bitswap-tracing
branch
from
June 20, 2024 15:43
fa5aaca
to
13f0d1b
Compare
aschmahmann
force-pushed
the
feat/more-bitswap-tracing
branch
from
June 20, 2024 16:32
13f0d1b
to
b1da22c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at adding some more visibility to the Bitswap tracing code path. This overall looks to be a good improvement, but I would expect the shape of the tracing (e.g. spans vs events, granularity and names of spans/events, etc.) to change over time here and don't think we want to commit to documenting each of those changes.
I'm labeling as skip/changelog, but happy to add some info if it makes sense.
Feedback definitely welcome 🙏