feat: tracing of gateway requests #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
commented
Jun 7, 2024
| `Authorization` header. The value of the `Authorization` header should match | ||
| the value in the `RAINBOW_TRACING_AUTH` environment variable. | ||
|
|
||
| ### `RAINBOW_SAMPLING_FRACTION` |
There was a problem hiding this comment.
In theory could invent an OTEL_TRACES_SAMPLER and OTEL_TRACES_SAMPLER_ARG if that makes more sense, but this seemed fine for now.
| }, | ||
| &cli.Float64Flag{ | ||
| Name: "sampling-fraction", | ||
| Value: 0, |
There was a problem hiding this comment.
Should this default to 1 instead of 0? I'd been using 0 with some testing to prevent flooding as I was more interested in Traceheaders, but the default OTEL sampler is "parentbased_always_on".
There was a problem hiding this comment.
A value of zero seems like the expected default, so that no sampling is done.
aschmahmann
force-pushed
the
feat/tracing
branch
from
9495073 to
dc7ef6e
Compare
lidel
added
the
need/maintainers-input
gammazero
reviewed
Jun 19, 2024
aschmahmann
force-pushed
the
feat/tracing
branch
from
dc7ef6e to
395c2e1
Compare
This was referenced Jun 24, 2024
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
lidel
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Lgtm.
Rebased on top of #150 to use release version of boxo and libp2p/go-libp2p-routing-helpers#84 + added changelog / some docs. Merging – I will continue and release tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates some dependencies (ipfs/boxo#615) to improve tracing while also:
cc @ns4plabs