Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

fix: round timestamps down by truncating them to seconds #41

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

Stebalien
Copy link
Member

Otherwise, we'll write timestamps in the future.

fixes ipfs/kubo#8406

Otherwise, we'll write timestamps in the future.

fixes ipfs/kubo#8406
@milahu
Copy link

milahu commented Sep 8, 2021

lgtm ; )

Copy link

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed IRL, I think this is worth fixing upstream too - their rounding in archive/tar/writer.go seems arbitrary, and added in 2017.

@Stebalien Stebalien merged commit 544b04d into master Sep 9, 2021
@Stebalien Stebalien deleted the fix/tar-time-rounding branch September 9, 2021 09:56
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 11, 2023
fix: round timestamps down by truncating them to seconds

This commit was moved from ipfs/go-ipfs-files@544b04d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api/v0/get?archive=true: tar: time stamp is in the future
3 participants