Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api/v0/get?archive=true: tar: time stamp is in the future #8406

Closed
3 tasks done
Tracked by #8343
milahu opened this issue Sep 4, 2021 · 6 comments · Fixed by ipfs/go-ipfs-files#41 or #8488
Closed
3 tasks done
Tracked by #8343

api/v0/get?archive=true: tar: time stamp is in the future #8406

milahu opened this issue Sep 4, 2021 · 6 comments · Fixed by ipfs/go-ipfs-files#41 or #8488
Labels
kind/bug A bug in existing code (including security flaws)
Milestone

Comments

@milahu
Copy link

milahu commented Sep 4, 2021

Checklist

Installation method

built from source

Version

go-ipfs version: 0.9.1
Repo version: 11
System version: amd64/linux
Golang version: go1.16.7

Config

not relevant

Description

api/v0/get?archive=true produces archives with future timestamps (error is less than one second)

this will throw many warnings when extracting that archive

reproduce:

arg=bafybeiflkjt66aetfgcrgvv75izymd5kc47g6luepqmfq6zsf5w6ueth6y # ipfs-desktop/assets/webui/
curl -X POST "http://localhost:5001/api/v0/get?archive=true&compress=false&arg=$arg" -o o.tar 
tar xf o.tar

output:

tar: <some-file>: time stamp 2021-09-04 14:24:46 is 0.291997891 s in the future
...

@milahu milahu added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Sep 4, 2021
@welcome
Copy link

welcome bot commented Sep 4, 2021

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@Stebalien
Copy link
Member

That's definitely not a bug in go-ipfs, it's likely NTP adjusting your clock. You can safely ignore the warning.

@Stebalien Stebalien reopened this Sep 5, 2021
@Stebalien
Copy link
Member

I... take that back. Go is rounding time up.

Stebalien added a commit to ipfs/go-ipfs-files that referenced this issue Sep 5, 2021
Otherwise, we'll write timestamps in the future.

fixes ipfs/kubo#8406
@Stebalien
Copy link
Member

Fix in ipfs/go-ipfs-files#41.

@Stebalien Stebalien removed the need/triage Needs initial labeling and prioritization label Sep 5, 2021
@milahu
Copy link
Author

milahu commented Sep 6, 2021

Go is rounding time up.

thanks for investigating : )

@Stebalien
Copy link
Member

(still needs to be bubbled)

lidel added a commit that referenced this issue Oct 5, 2021
lidel added a commit that referenced this issue Oct 5, 2021
lidel added a commit that referenced this issue Oct 5, 2021
@guseggert guseggert mentioned this issue Nov 23, 2021
80 tasks
hacdias pushed a commit to ipfs/boxo that referenced this issue Jan 11, 2023
Otherwise, we'll write timestamps in the future.

fixes ipfs/kubo#8406


This commit was moved from ipfs/go-ipfs-files@3dadb7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
2 participants