This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Send all the precisions we have in the dates #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
I smoke tested this in ipfs/kubo#9206 (comment) and looks fine.
On the formal side of things, our OpenAPI spec defines these fields as date-time, which is defined by RFC 3339, section 5.6 and optional time-secfrac is part of that spec. I've updated examples in ipfs/pinning-services-api-spec#104 but it is only documentation change.
I think this is 👍 – feel free to merge and tag a patch release, and then bubble it up to ipfs/kubo#8762
|
I dont want to merge before 0.15 is out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround attempt for ipfs/kubo#8762 while
nextTokenis being speced and implemented.This need testing I'm not sure all pinning services support this date format.