Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go-pinning-service-http-client to include up to nano precision #9206

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Aug 18, 2022

Workaround for #8762
Depends on ipfs/go-pinning-service-http-client#20

@lidel
Copy link
Member

lidel commented Aug 18, 2022

@Jorropo fwiw I have 25 pins and estuary and web3.storage – adding pins and paginating over them works fine 👍

Below should show 0-25 in order, latest to oldest (Kubo does pagination by fetching batches of 10):

$ ipfs pin remote ls --service=web3-storage --status=queued
QmbCpjNfbwbMvJqMUUHAoDAjNqdoZFo7zWEGBkCCWEZ6nA	queued	test-pin-25
QmfQvgMkYj77amUviAqCT2kf3QkwsiCFRYc21SfPXSkpn8	queued	test-pin-24
QmbqbK7pakRu2rmp38rKpp1EwnDZ9ikQbQrYiQ3sAMeofR	queued	test-pin-23
QmTPZEhFu9tRcxNEvexkhz3Zoi4U9t9mmGncfhKqt1VyGf	queued	test-pin-22
QmNThD2GkZMtzWoDvuHjb2XQnSH5NEFgWwzR5h6cqVZkB9	queued	test-pin-21
QmUqgwLckMg5QvdtXgd9WES726TqfoTX3fRpsV57cy79YU	queued	test-pin-20
QmQTzvHwJZ8N3G8tQdiZ9ykGD3Nnxb5cyUh9tJRSXLeAmT	queued	test-pin-19
QmfPN5b8nZdGNeqBtZtQu7V2GSnfUKM3fg1HGFnzfB9GoY	queued	test-pin-18
QmZqzBwfCLSqN7VauZHQHnQPt925CGFy3XoT6HxJ32cZS5	queued	test-pin-17
QmekSUExxjF1pycq1DtaQZyHtMq6kCNjVB3ZogSdgEguB2	queued	test-pin-16
QmekSUExxjF1pycq1DtaQZyHtMq6kCNjVB3ZogSdgEguB2	queued	test-pin-16
QmaHq597QaoiqjHjwbFz2DKxjuezkPVhQ5iwGF5gxfNHb4	queued	test-pin-15
QmRAaaZxYDdWjTERbPENBtqoC5aDnc5vf4Qg472ssnyCic	queued	test-pin-14
QmU718ekePHsiEVhbRRvmRhkGb4aJwqeCoqGSD6mvdXSG6	queued	test-pin-13
QmdoX2NpQU7YpZzGqEAXjX4xAzkWAmFMtrHvwEgrN7vQpk	queued	test-pin-12
QmNtaCdRAmsR2cG4dvhfAc8eZv1kaGYoAPGZjec2KY4yG6	queued	test-pin-11
QmUnKvaCFaE8DSHMAq2XeHfrz1wW62uVbb4dNtxQ5zXy6n	queued	test-pin-10
QmSRQJmXLc6xBHHfrFu2CmtJa9ep4wRwhy7oky8tH4P74J	queued	test-pin-9
QmYvu7a4kcf1drqHfZNDdoyVbPHnS3LmDsao9YrAVBmfjP	queued	test-pin-8
QmaHbbushv2gYBUyofdm853cy1HTcNuinqagCfMjMdGmNw	queued	test-pin-7
QmaHbbushv2gYBUyofdm853cy1HTcNuinqagCfMjMdGmNw	queued	test-pin-7
QmQXqZdEwXnWgKpfJmUVaACuVar9R7vpBxtZgddQMTa2UN	queued	test-pin-6
QmZa1tLVa8iEoDWbvwxV7rCxGnVGUff2jhF7a2DyCk5SbY	queued	test-pin-5
QmR56UJmAaZLXLdTT1ALrE9vVqV8soUEekm9BMd4FnuYqV	queued	test-pin-4
QmdQEnYhrhgFKPCq5eKc7xb1k7rKyb3fGMitUPKvFAscVK	queued	test-pin-3
QmSFxnK675wQ9Kc1uqWKyJUaNxvSc2BP5DbXCD3x93oq61	queued	test-pin-2
QmdytmR4wULMd3SLo6ePF4s3WcRHWcpnJZ7bHhoj3QB13v	queued	test-pin-1
QmUQcSjQx2bg4cSe2rUZyQi6F8QtJFJb74fWL7D784UWf9	queued	test-pin-0

(same for Estuary).

Pinata pagination is broken, but it is also broken in 0.15-rc1,
so not related to this PR. I filled ipfs-shipyard/pinning-service-compliance#179 if you are interested in details.

@Jorropo Jorropo force-pushed the more-precision-in-pinning branch from c369dd5 to c77c726 Compare September 1, 2022 11:51
@Jorropo Jorropo marked this pull request as ready for review September 1, 2022 11:51
@Jorropo Jorropo enabled auto-merge (rebase) September 1, 2022 11:51
@Jorropo Jorropo force-pushed the more-precision-in-pinning branch from c77c726 to 3c531b7 Compare September 1, 2022 13:23
@Jorropo Jorropo disabled auto-merge September 1, 2022 13:36
@Jorropo Jorropo merged commit 849e047 into ipfs:master Sep 1, 2022
@Jorropo Jorropo deleted the more-precision-in-pinning branch September 1, 2022 13:36
@Jorropo Jorropo restored the more-precision-in-pinning branch December 12, 2022 22:32
@Jorropo Jorropo deleted the more-precision-in-pinning branch December 12, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants