fix: add cross-impl shard test #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
added a commit
to ipfs/js-ipfs-unixfs
that referenced
this pull request
Aug 25, 2023
rvagg
force-pushed
the
rvagg/fanout-tests
branch
from
5dc87da
to
a3996b8
Compare
willscott
approved these changes
Aug 25, 2023
rvagg
added a commit
to ipfs/js-ipfs-unixfs
that referenced
this pull request
Aug 25, 2023
rvagg
added a commit
to ipfs/js-ipfs-unixfs
that referenced
this pull request
Aug 25, 2023
rvagg
added a commit
to ipfs/js-ipfs-unixfs
that referenced
this pull request
Aug 25, 2023
achingbrain
pushed a commit
to ipfs/js-ipfs-unixfs
that referenced
this pull request
Aug 25, 2023
Ref: ipfs/go-unixfsnode#66 The material change in here is the path cleaner/splitter; it's a bit too aggressive. It doesn't allow `\` as a file name and the `.trim()` discounts valid file names. Otherwise this is a match for ipfs/go-unixfsnode#66 and gets the same CID on importer, and tests the exporter can read the same data.
rvagg
force-pushed
the
rvagg/fanout-tests
branch
from
a3996b8
to
4ee8c74
Compare
|
merged in JS ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same test going in https://github.com/ipfs/js-ipfs-unixfs
Edit: ipfs/js-ipfs-unixfs#358