Skip to content

Commit

Permalink
fix: add cross-impl shard test, fix path cleaner
Browse files Browse the repository at this point in the history
  • Loading branch information
rvagg committed Aug 25, 2023
1 parent f2fc563 commit b0ef506
Show file tree
Hide file tree
Showing 2 changed files with 76 additions and 32 deletions.
103 changes: 75 additions & 28 deletions packages/ipfs-unixfs-exporter/test/exporter-sharded.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -256,40 +256,87 @@ describe('exporter sharded', function () {
expect(exported.name).to.deep.equal('file-1')
})

it('exports a shard with a different fanout size', async () => {
const files: ImportCandidate[] = [{
path: '/baz.txt',
content: Uint8Array.from([0, 1, 2, 3, 4])
}, {
path: '/foo.txt',
content: Uint8Array.from([0, 1, 2, 3, 4])
}, {
path: '/bar.txt',
content: Uint8Array.from([0, 1, 2, 3, 4])
}]
describe('alternate fanout size', function () {
it('exports a shard with a fanout of 16', async () => {
const files: ImportCandidate[] = [{
path: '/baz.txt',
content: Uint8Array.from([0, 1, 2, 3, 4])
}, {
path: '/foo.txt',
content: Uint8Array.from([0, 1, 2, 3, 4])
}, {
path: '/bar.txt',
content: Uint8Array.from([0, 1, 2, 3, 4])
}]

const result = await last(importer(files, block, {
shardSplitThresholdBytes: 0,
shardFanoutBits: 4, // 2**4 = 16 children max
wrapWithDirectory: true
}))
const result = await last(importer(files, block, {
shardSplitThresholdBytes: 0,
shardFanoutBits: 4, // 2**4 = 16 children max
wrapWithDirectory: true
}))

if (result == null) {
throw new Error('Import failed')
}
if (result == null) {
throw new Error('Import failed')
}

const { cid } = result
const dir = await exporter(cid, block)
const { cid } = result
const dir = await exporter(cid, block)

expect(dir).to.have.nested.property('unixfs.fanout', 16n)

const contents = await all(dir.content())

expect(dir).to.have.nested.property('unixfs.fanout', 16n)
expect(contents.map(entry => ({
path: `/${entry.name}`,
content: entry.node
})))
.to.deep.equal(files)
})

// Cross-impl reference test: directory of files with single character
// names, starting from ' ' and ending with '~', but excluding the special
// characters '/' and '.'. Each file should contain a single byte with the
// same value as the character in its name. Files are added to a sharded
// directory with a fanout of 16, using CIDv1 throughout, and should result
// in the root CID of:
// bafybeihnipspiyy3dctpcx7lv655qpiuy52d7b2fzs52dtrjqwmvbiux44
it('reference shard with fanout of 16', async () => {
const files: ImportCandidate[] = []
for (let ch = ' '.charCodeAt(0); ch <= '~'.charCodeAt(0); ch++) {
if (ch === 47 || ch === 46) { // skip '/' and '.'
continue
}
files.push({
path: String.fromCharCode(ch),
content: Uint8Array.from([ch])
})
}

const contents = await all(dir.content())
const result = await last(importer(files, block, {
shardSplitThresholdBytes: 0,
shardFanoutBits: 4,
wrapWithDirectory: true
}))

expect(contents.map(entry => ({
path: `/${entry.name}`,
content: entry.node
})))
.to.deep.equal(files)
if (result == null) {
throw new Error('Import failed')
}

const { cid } = result
expect(cid.toString()).to.equal('bafybeihnipspiyy3dctpcx7lv655qpiuy52d7b2fzs52dtrjqwmvbiux44')

const dir = await exporter(cid, block)

expect(dir).to.have.nested.property('unixfs.fanout', 16n)

let contents = await all(dir.content())
contents = contents.map(entry => ({
path: `${entry.name}`,
content: entry.node
}))
contents.sort((a, b) => a.content[0] < b.content[0] ? -1 : 1)
expect(contents).to.deep.equal(files)
})
})

it('walks path of a HAMT with a different fanout size', async () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
export const toPathComponents = (path: string = ''): string[] => {
// split on / unless escaped with \
return (path
.trim()
.match(/([^\\/]|\\\/)+/g) ?? [])
.filter(Boolean)
return path.split(/(?<!\\)\//).filter(Boolean)
}

0 comments on commit b0ef506

Please sign in to comment.